Skip to content

Conversation

@bzz
Copy link
Member

@bzz bzz commented Aug 2, 2016

What is this PR for?

Small cleanup of zeppelin-server tests

What type of PR is it?

Refactoring

How should this be tested?

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
Copy link
Member Author

bzz commented Aug 3, 2016

CI failed due to ZEPPELIN-1264

Rebasing on latest master and merging, if there is no further discusison

@bzz bzz force-pushed the cleanup/zeppelin-server-tests branch from 95462d6 to ce911cf Compare August 3, 2016 00:52
@bzz
Copy link
Member Author

bzz commented Aug 3, 2016

CI failure

Results :

Failed tests: 
  ZeppelinSparkClusterTest.sparkRTest:116 expected:<[[1] 3]> but was:<[<pre><code>Error in getSparkSession(): SparkSession not initialized
</code></pre>

<pre><code>Error in (function (classes, fdef, mtable) : unable to find an inherited method for function 'count' for signature '&quot;function&quot;'
</code></pre>]>

Tests run: 65, Failures: 1, Errors: 0, Skipped: 0

Fixed in #1259 so rebasing again

@bzz bzz force-pushed the cleanup/zeppelin-server-tests branch from ce911cf to 0dd89ca Compare August 3, 2016 05:23
@jongyoul
Copy link
Member

jongyoul commented Aug 3, 2016

I like this kind of PR. LGTM. Thanks for cleaning tests and removing unnecessary class.

@bzz
Copy link
Member Author

bzz commented Aug 4, 2016

Thank you for review @jongyoul !

CI fails on spark 1.6 profile, same as master, handled under ZEPPELIN-1286

Merging if there is no further discussion.

@bzz bzz mentioned this pull request Aug 4, 2016
2 tasks
@asfgit asfgit closed this in cf327f8 Aug 5, 2016
@bzz bzz deleted the cleanup/zeppelin-server-tests branch August 5, 2016 03:09
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
Small cleanup of zeppelin-server tests

### What type of PR is it?
Refactoring

### How should this be tested?

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Alexander Bezzubov <[email protected]>

Closes apache#1263 from bzz/cleanup/zeppelin-server-tests and squashes the following commits:

0dd89ca [Alexander Bezzubov] Small cleanup of org.apache.zeppelin.* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants